-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated prometheus metrics from MS #432
Conversation
keda-operator is also exposing metrics on default port 8080 like keda_scaler_, keda_scaled_objects_, keda_resource_* or keda_trigger_*. There are no annotations for that currently, we would need to add:
in https://github.com/kedacore/charts/tree/main/keda/templates/manager/deployment.yaml |
nice catches! |
@JorTurFer could you please rebase this PR? |
Yes, I'll do it during this week |
I still got this pending but I'm out of the office :( |
a8ef126
to
a49d7d0
Compare
done! |
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
e8dd757
to
a3b97a7
Compare
Signed-off-by: Jorge Turrado <[email protected]>
PTAL @zroubalik , we need to merge this because the chart is "broken" until it due to the parameters change in MS |
@JorTurFer @zroubalik @tomkerkhove my apologies for the multi-mention but I've just hit this and I was wondering if you're willing to push up a revision of the current KEDA chart to contain this and few other commits? |
No worries for the mention 😄 |
Checklist
Related to kedacore/keda#3930